NTP BUG 3382: Data Structure terminated insufficiently (Windows installer ONLY)
Last update: June 27, 2022 20:45 UTC (51d68a4aa)
Summary
Description
The Windows installer for NTP calls strcpy()
with an argument that specifically contains multiple null bytes. strcpy()
only copies a single terminating null character into the target buffer instead of copying the required double null bytes in the addKeysToRegistry()
function. As a consequence, a garbage registry entry can be created. The additional arsize
parameter is erroneously set to contain two null bytes and the following call to RegSetValueEx()
claims to be passing in a multi-string value, though this may not be true.
Mitigation
Credit
This weakness was discovered by Cure53.
Timeline